[Prism] Fix Reshuffle handling to recursively remove sub-transforms#38735
Conversation
…sforms Updates `handleReshuffle` in the Go Prism runner to recursively clean up all nested sub-transforms of a Reshuffle composite transform using `removeSubTransforms`. This prevents nested sub-transforms from being processed in subsequent graph optimization stages.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the Go Prism runner's handling of Reshuffle composite transforms. By ensuring that all nested sub-transforms are recursively removed during the handling process, the runner avoids issues where stale or orphaned transforms interfere with later stages of the pipeline graph optimization. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Prism runner's reshuffle handler to recursively remove all sub-transforms by calling removeSubTransforms instead of only removing the top-level sub-transforms. Additionally, a new unit test TestHandleReshuffle is added to verify this recursive removal and the correct remapping of consumer inputs. No review comments were provided, and there is no additional feedback.
|
r: @lostluck |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
2 participants
Updates
handleReshufflein the Go Prism runner to recursively clean up all nested sub-transforms of a Reshuffle composite transform usingremoveSubTransforms.This prevents nested sub-transforms from being processed in subsequent graph optimization stages.
For example, prior to the change, we can see the following stage dump where stage-002, stage-003, stage-004 are from Reshuffle. They have -inf watermark and never have any bundle and stage-002 is connected to a dummy IMPULSE.